I usually use a blend of apple and pecan with a little cherry for color, but if I have to pick only one it's apple because I have a lot of apple orchards where I live.
I'm a pecan man myself, I'm surrounded by 4 100+ year old trees. Pecan to me is underestimated and if you haven't tried it you should. It's a good general use wood that works for anything. I consider it a step above apple