I always find myself going to my Traeger Texas pellet grill. It always puts out good food, very convenient, more than enough capacity for nearly everything, and I don't have to worry about it. My UDS comes in a close second, though it's capacity is less than the Traeger, sometimes I just need that charcoal flavor.
I wish I had a nice big reverse flow smoker with the side firebox to burn sticks. This seems like the way to get the best flavor into the food, but they are expensive, and generally take a while to get started, which might get annoying. I haven't been able to justify getting one, yet...
I just purchased a Weber 26.75" OTG that I am hoping will turn into my do all grill/smoker, but I need to get some time on it and figure out it's best setup to smoke with.
XL Big Green Egg, Weber Performer Platinum, WSM 22.5"